Skip to content

Rename standards.h header file #8093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
reshmavk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Rename standards.h header file #8093

reshmavk wants to merge 1 commit into from
+68 −68

Conversation

@reshmavk
Copy link
Contributor

@reshmavk reshmavk commented Jan 7, 2026

Compilation of cppcheck fails in AIX fails with multiple undeclared errors as shown below:

/opt/freeware/lib/gcc/powerpc-ibm-aix7.1.0.0/10/include/c++/cstdint:47:11: error: 'int8_t' has not been declared in '::'
   47 |   using ::int8_t;
      |           ^~~~~~
/opt/freeware/lib/gcc/powerpc-ibm-aix7.1.0.0/10/include/c++/cstdint:48:11: error: 'int16_t' has not been declared in '::'
   48 |   using ::int16_t;
      |           ^~~~~~~
/opt/freeware/lib/gcc/powerpc-ibm-aix7.1.0.0/10/include/c++/cstdint:49:11: error: 'int32_t' has not been declared in '::'
   49 |   using ::int32_t;
      |           ^~~~~~~
/opt/freeware/lib/gcc/powerpc-ibm-aix7.1.0.0/10/include/c++/cstdint:50:11: error: 'int64_t' has not been declared in '::'
   50 |   using ::int64_t;
      |           ^~~~~~~
/opt/freeware/lib/gcc/powerpc-ibm-aix7.1.0.0/10/include/c++/cstdint:52:11: error: 'int_fast8_t' has not been declared in '::'
   52 |   using ::int_fast8_t;
      |           ^~~~~~~~~~~
/opt/freeware/lib/gcc/powerpc-ibm-aix7.1.0.0/10/include/c++/cstdint:53:11: error: 'int_fast16_t' has not been declared in '::'

AIX has a system header file named standards.h which defines certain macros based on which types like int8_t,int16_t,etc are defined in stdint.h header file. Since cppcheck also has a header file named standards.h and this takes precedence over the system header file during compilation, system provided standards.h is not included resulting in the above mentioned errors. For more information please refer https://sourceforge.net/p/cppcheck/discussion/development/thread/b5b3f765b4/

To resolve this issue, this PR implements a possible solution: cppcheck provided standards.h has been renamed to cppcheckstd.h and #include "standards.h" has been replaced with #include "cppcheckstd.h" wherever required in the source code.

Could you please let me know if these changes are acceptable to merge or if there is a better approach to address this issue. I appreciate your suggestions.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 7, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@chrchr-github
Copy link
Collaborator

chrchr-github commented Jan 8, 2026

Thanks for your contribution. For consistency, please rename standards.cpp to cppcheckstd.cpp.
You also need to replace all references to standards.h in Makefile and in https://github.com/reshmavk/cppcheck/blob/rename_standards/tools/dmake/dmake.cpp

@firewave
Copy link
Collaborator

firewave commented Jan 8, 2026 •
edited
Loading 

In file included from /home/buildusr/reshma/patch_contribution/cppcheck/lib/standards.h:24,
                 from /opt/freeware/lib/gcc/powerpc-ibm-aix7.1.0.0/10/include-fixed/wchar.h:44,
                 from /opt/freeware/lib/gcc/powerpc-ibm-aix7.1.0.0/10/include/c++/cwchar:44,
                 from /opt/freeware/lib/gcc/powerpc-ibm-aix7.1.0.0/10/include/c++/bits/postypes.h:40,
                 from /opt/freeware/lib/gcc/powerpc-ibm-aix7.1.0.0/10/include/c++/bits/char_traits.h:40,
                 from /opt/freeware/lib/gcc/powerpc-ibm-aix7.1.0.0/10/include/c++/string:40,
                 from /home/buildusr/reshma/patch_contribution/cppcheck/lib/matchcompiler.h:23,
                 from /home/buildusr/reshma/patch_contribution/cppcheck/build/lib/build/mc_valueflow.cpp:1:
/home/buildusr/reshma/patch_contribution/cppcheck/lib/config.h:137:26: error: aggregate 'const string emptyString' has incomplete type and cannot be defined
  137 | static const std::string emptyString;
      |                          ^~~~~~~~~~~

I still do not understand how a system include can utilize a local include as those should be separated. That means that any project could "poison" the system ones. Seems like there is a bug in the compiler or the project is misconfigured.

I also do not like the new name as naming something cppcheck*.* is redundant and does not reflect the contents.

@danmar
Copy link
Owner

danmar commented Jan 8, 2026

@reshmavk do you have a real AIX machine or do you use some cloud service that we could test?

@reshmavk
Copy link
Contributor Author

reshmavk commented Jan 20, 2026

I use a real AIX machine, not from the cloud.
Here is a sample code that can reproduce this issue.
main.cpp

#include "standards.h"
#include <iostream>

void say_hello(uint8_t times) {
    for (uint8_t i = 0; i < times; ++i) {
        std::cout << "Hello, World! [" << static_cast<int>(i + 1) << "]" << std::endl;
    }
}

int main() {
    say_hello(3);  // Print Hello World 3 times
    return 0;
}

standards.h

#ifndef HELLO_HPP
#define HELLO_HPP

#include <cstdint>  // Use <stdint.h> if you prefer C-style

void say_hello(uint8_t times);

#endif // HELLO_HPP

The error occurs when compiled using g++ -I<local_path_to_standards.h> main.cpp -o main -lstdc++

@danmar
Copy link
Owner

danmar commented Jan 28, 2026 •
edited
Loading

@firewave I can reproduce something similar on my debian machine. I put two files in current folder 1.c and stddef.h.

1.c:

#include <stdio.h>
int main() {
    return 0;
}

stddef.h

#error BAD

on my machine stdio.h includes stddef.h using angle brackets:

$ grep stddef.h /usr/include/stdio.h
#include <stddef.h>

my stddef.h in local folder gets included:

$ gcc -I/home/daniel/cppchecksolutions/cppcheck 1.c
In file included from /usr/include/stdio.h:33,
                 from 1.c:2:
/home/daniel/cppchecksolutions/cppcheck/stddef.h:1:2: error: #error BAD
    1 | #error BAD
      |  ^~~~~

If I remove the -I... from the gcc command it compiles.

@danmar
Copy link
Owner

danmar commented Jan 28, 2026

the first suggestion by chat gpt is to not reuse header filenames. but.. who says that it's only standards.h

we can include using more specific paths i.e.: #include "cppcheck/lib/standards.h". but ugh I have a bad feeling about replacing all the paths..

I don't have very great ideas right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@reshmavk @chrchr-github @firewave @danmar